conversions between [u8; 4] and Color #8564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
approved these changes
May 7, 2023
crates/bevy_render/src/color/mod.rs
Outdated
| pub fn as_rgba_u8(&self) -> [u8; 4] { | ||
| let [r, g, b, a] = self.as_rgba_f32(); | ||
| [ | ||
| (r * 255.0) as u8, |
There was a problem hiding this comment.
For those wondering like me, values less than 0 will cast to 0 and values greater than 255 will cast to 255. So this should be okay since we expect each component to be in the range [0, 1] anyways.
There was a problem hiding this comment.
0will cast to0and values greater than255will cast to255.
I didn't actually know that but that's good to know haha
Co-authored-by: Gino Valente <[email protected]>
alice-i-cecile
approved these changes
May 8, 2023
alice-i-cecile
added
A-Rendering
|
I like that this is more explicit: very easy to trip yourself up with color space casting. |
mockersf
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
- Implement From for [u8; 4]- also implement From<[u8; 4]> for Color because why not.as_rgba_u8in Color