Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix many_sprites and many_animated_sprites crash #8783

Closed
wants to merge 1 commit into from
Closed

Fix many_sprites and many_animated_sprites crash #8783

wants to merge 1 commit into from

Conversation

opstic
Copy link
Contributor

@opstic opstic commented Jun 8, 2023

Objective

Solution

  • Change the plugin initialization order so that the diagnostics plugins get added after DiagnosticsPlugin

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash A-App Bevy apps and plugins A-Diagnostics Logging, crash handling, error reporting and performance analysis and removed A-App Bevy apps and plugins labels Jun 8, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jun 8, 2023
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash labels Jun 8, 2023
@mockersf
Copy link
Member

instead of doing this and #8785, we could change the function register_diagnostic to create the resource if not already present, and then the DiagnosticPlugin to reuse it if already present

@mockersf mockersf mentioned this pull request Jun 10, 2023
Closed
@alice-i-cecile alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label Jun 11, 2023
@alice-i-cecile
Copy link
Member

I like that fix better: there's no reason not to just make this robust.

@opstic
Copy link
Contributor Author

opstic commented Jun 11, 2023

Closing in favor of #8819

@opstic opstic closed this Jun 11, 2023
@opstic opstic deleted the fix-plugin-order branch June 13, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

many_sprites and many_animated_sprites crashing on initialization
3 participants
@opstic @mockersf @alice-i-cecile