Added Has<T> WorldQuery type #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Feature
alice-i-cecile
requested changes
Jun 15, 2023
Co-authored-by: Alice Cecile <[email protected]>
… into has-worldquery
Co-authored-by: Alice Cecile <[email protected]>
… into has-worldquery
alice-i-cecile
approved these changes
Jun 15, 2023
Co-authored-by: Alice Cecile <[email protected]>
konsti219
reviewed
Jun 15, 2023
JoJoJet
approved these changes
Jun 15, 2023
Aceeri
approved these changes
Jun 15, 2023
james7132
reviewed
Jun 15, 2023
|
@wainwrightmark can you try out the suggestion from James and report back? Once that's done (success or failure), I'm happy to merge this and ship it for 0.11 :) |
|
Replacing |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Co-authored-by: JoJoJet <[email protected]>
|
I realize I have made a mistake in making |
alice-i-cecile
approved these changes
Jun 19, 2023
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 19, 2023
# Objective - Fixes bevyengine#7811 ## Solution - I added `Has<T>` (and `HasFetch<T>` ) and implemented `WorldQuery`, `ReadonlyWorldQuery`, and `ArchetypeFilter` it - I also added documentation with an example and a unit test I believe I've done everything right but this is my first contribution and I'm not an ECS expert so someone who is should probably check my implementation. I based it on what `Or<With<T>,>`, would do. The only difference is that `Has` does not update component access - adding `Has` to a query should never affect whether or not it is disjoint with another query *I think*. --- ## Changelog ## Added - Added `Has<T>` WorldQuery to find out whether or not an entity has a particular component. --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: JoJoJet <[email protected]>
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Has<C>WorldQuerytype to replaceOption<&C>when checking existence #7811Solution
Has<T>(andHasFetch<T>) and implementedWorldQuery,ReadonlyWorldQuery, andArchetypeFilteritI believe I've done everything right but this is my first contribution and I'm not an ECS expert so someone who is should probably check my implementation. I based it on what
Or<With<T>,>, would do. The only difference is thatHasdoes not update component access - addingHasto a query should never affect whether or not it is disjoint with another query I think.Changelog
Added
Has<T>WorldQuery to find out whether or not an entity has a particular component.