Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maximum_delta to Time #8915

Closed
wants to merge 1 commit into from
Closed

Add maximum_delta to Time #8915

wants to merge 1 commit into from

Conversation

nakedible
Copy link
Contributor

THIS PULL IS STILL INCOMPLETE, I JUST CREATED IT TO MORE EASILY DISCUSS IF THE WORK SHOULD BE FINISHED

Objective

  • Describe the objective or issue this PR addresses.
  • If you're fixing a specific issue, say "Fixes #X".

Solution

  • Describe the solution used to achieve the objective above.

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

  • What changed as a result of this PR?
  • If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
  • Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
    • If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

  • If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
  • Simply adding new functionality is not a breaking change.
  • Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

@nakedible nakedible force-pushed the maximum-delta-time branch from 60741ad to cd7f3c7 Compare June 21, 2023 13:20
@nakedible nakedible force-pushed the maximum-delta-time branch from cd7f3c7 to c94f49b Compare June 21, 2023 13:22
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Time Involves time keeping and reporting labels Jun 21, 2023
@alice-i-cecile
Copy link
Member

Competes with #8544.

@alice-i-cecile alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label Jun 21, 2023
@alice-i-cecile alice-i-cecile mentioned this pull request Jun 21, 2023
Closed
@nakedible
Copy link
Contributor Author

Closing in favor of #8964

@nakedible nakedible closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nakedible @alice-i-cecile