Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy::default_constructed_unit_structs and trybuild errors #9144

Merged
merged 3 commits into from
Jul 13, 2023
Merged

fix clippy::default_constructed_unit_structs and trybuild errors #9144

merged 3 commits into from
Jul 13, 2023

Conversation

tguichaoua
Copy link
Contributor

@tguichaoua tguichaoua commented Jul 13, 2023 •
edited
Loading

Objective

With Rust 1.71.0 (released a few minutes ago), clippy introduced a new lint (default_constructed_unit_structs) wich prevent calling default() on unit structs (e.g. PhantomData::default()).

Solution

Apply the lint suggestion.

@mockersf
Copy link
Member

could you also fix the check-compiles job? it seems there has been a small change in one of the error message we test

@mockersf mockersf added the C-Code-Quality A section of code that is hard to understand or change label Jul 13, 2023
@tguichaoua
Copy link
Contributor Author

could you also fix the check-compiles job? it seems there has been a small change in one of the error message we test

I'm not available for the next hours. It would be faster to do it in another PR.

@Selene-Amanita Selene-Amanita mentioned this pull request Jul 13, 2023
Merged
@cart cart changed the title fix clippy::default_constructed_unit_structs fix clippy::default_constructed_unit_structs and trybuild errors Jul 13, 2023
@cart cart enabled auto-merge July 13, 2023 21:20
@cart cart added this pull request to the merge queue Jul 13, 2023
@SpecificProtagonist SpecificProtagonist mentioned this pull request Jul 13, 2023
Closed
Merged via the queue into bevyengine:main with commit 30d897a Jul 13, 2023
@tguichaoua tguichaoua deleted the lint/fix_default_constructed_unit_structs branch July 13, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tguichaoua @mockersf @cart