hacks for running (and screenshotting) the examples in CI on a github runner #9220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Build-System
nicopap
reviewed
Jul 21, 2023
|
moved to git patch, thanks for the idea! it makes it a lot clearer than my sed commands |
nicopap
approved these changes
Jul 25, 2023
mockersf
force-pushed
the
example-showcase-can-remove-desktop-mode
branch
from
40a5da0 to
0efe653
Compare
rparrett
reviewed
Aug 30, 2023
rparrett
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
I'm assuming that this has been pretty well tested over at https://vleue.com/bevy-example-tests/ by this point?
Couple pieces of non-blocking feedback / future ideas while playing with this locally:
- It would be cool if there was a mode that exited immediately after screenshotting. Probably harder than it sounds with screenshotting happening in an async task in the render app?
- It would be cool if we could patch such that newly created windows do not steal focus. I can't seem to make this work on macos and opened macos: create unfocused window rust-windowing/winit#3072
Co-authored-by: Rob Parrett <[email protected]>
mockersf
force-pushed
the
example-showcase-can-remove-desktop-mode
branch
from
efbaa15 to
fcdd04d
Compare
|
I would like to merge this PR before the 0.12 to write a more complete story for the blog post. It already has the two approvals needed, but the last commit hasn't been reviewed yet. It adds a patch for window creation to ensure its position is always the same on windows, to be able to have a predictable cursor position in the window. @rparrett or @nicopap (or someone else), could you give this a new approval? thanks! |
rparrett
approved these changes
Oct 13, 2023
nicopap
approved these changes
Oct 13, 2023
mockersf
added
the
S-Ready-For-Final-Review
|
thanks! |
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
… runner (bevyengine#9220) # Objective - Enable capturing screenshots of all examples in CI on a GitHub runner ## Solution - Shorten duration of a run - Disable `desktop_app` mode - as there isn't any input in CI, examples using this take way too long to run - Change the default `ClusterConfig` - the runner are not able to do all the clusters with the default settings - Send extra `WindowResized` events - this is needed only for the `split_screen` example, because CI doesn't trigger that event unlike all the other platforms --------- Co-authored-by: Rob Parrett <[email protected]>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
… runner (bevyengine#9220) # Objective - Enable capturing screenshots of all examples in CI on a GitHub runner ## Solution - Shorten duration of a run - Disable `desktop_app` mode - as there isn't any input in CI, examples using this take way too long to run - Change the default `ClusterConfig` - the runner are not able to do all the clusters with the default settings - Send extra `WindowResized` events - this is needed only for the `split_screen` example, because CI doesn't trigger that event unlike all the other platforms --------- Co-authored-by: Rob Parrett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
desktop_appmode - as there isn't any input in CI, examples using this take way too long to runClusterConfig- the runner are not able to do all the clusters with the default settingsWindowResizedevents - this is needed only for thesplit_screenexample, because CI doesn't trigger that event unlike all the other platforms