Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl feature renamed to webgl2 #9370

Merged
merged 5 commits into from
Aug 12, 2023
Merged

Conversation

sebosp
Copy link
Contributor

@sebosp sebosp commented Aug 6, 2023

Addresses:

$ cargo build --release --example lighting --target wasm32-unknown-unknown --features webgl
error: none of the selected packages contains these features: webgl, did you mean: webgl2, webp?

Objective

  • When following the instructions for the web examples.
  • Document clearly the generated file ./target/wasm_example.js, since it didn't appear on git grep (missing extension)

Solution

  • Follow the feature rename on the docs.

error: none of the selected packages contains these features: webgl, did you mean: webgl2, webp?
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

You added a new example but didn't update the readme. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

@rparrett
Copy link
Contributor

rparrett commented Aug 6, 2023

I don't think it's necessary to specify the feature at all, actually. webgl2 is a default feature.

@rparrett rparrett added C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples O-WebGL2 Specific to the WebGL2 render API labels Aug 6, 2023
@JMS55
Copy link
Contributor

JMS55 commented Aug 7, 2023

Interestingly enough, the bevy_pbr feature is still called webgl. It's just that bevy_internal re-exports it as webgl2...

@sebosp
Copy link
Contributor Author

sebosp commented Aug 7, 2023

Removed the --features webgl2 since as you mention it's not default. Or would you prefer to have it another way?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

You added a new example but didn't update the readme. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

You added a new example but didn't update the readme. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

@mockersf
Copy link
Member

mockersf commented Aug 7, 2023

Interestingly enough, the bevy_pbr feature is still called webgl. It's just that bevy_internal re-exports it as webgl2...

In Bevy, the internal feature is kept as webgl as that's the name of the wgpu feature. But the external feature is webgl2 as I don't think it would work with WebGL1.

github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2023
…9372)

# Objective

Provide a slightly better message when a contributor needs to update the
generated example readme file for [any number of
reasons](#9372 (comment))
but hasn't added any examples.

This recently happened here:
#9370 (comment)

The contributor modified the readme template and is being told that they
added an example.

## Solution

The advice given is still correct. Just change the message so that it's
not accusing the contributor of adding an example.

It may be possible to instead add more specific messages instead if
someone is motivated to do that.

edit: reworked this whole PR text

---------

Co-authored-by: Nicola Papale <[email protected]>
@mockersf mockersf added this pull request to the merge queue Aug 12, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 12, 2023
Merged via the queue into bevyengine:main with commit e489dcc Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples O-WebGL2 Specific to the WebGL2 render API S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants