-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webgl feature renamed to webgl2 #9370
Conversation
error: none of the selected packages contains these features: webgl, did you mean: webgl2, webp?
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
You added a new example but didn't update the readme. Please run |
Signed-off-by: Seb Ospina <[email protected]>
I don't think it's necessary to specify the feature at all, actually. |
Interestingly enough, the bevy_pbr feature is still called webgl. It's just that bevy_internal re-exports it as webgl2... |
…e referenced file wasm_example.js is generated
…get the file wasm_example.js
Removed the |
You added a new example but didn't update the readme. Please run |
1 similar comment
You added a new example but didn't update the readme. Please run |
In Bevy, the internal feature is kept as |
Signed-off-by: Seb Ospina <[email protected]>
…9372) # Objective Provide a slightly better message when a contributor needs to update the generated example readme file for [any number of reasons](#9372 (comment)) but hasn't added any examples. This recently happened here: #9370 (comment) The contributor modified the readme template and is being told that they added an example. ## Solution The advice given is still correct. Just change the message so that it's not accusing the contributor of adding an example. It may be possible to instead add more specific messages instead if someone is motivated to do that. edit: reworked this whole PR text --------- Co-authored-by: Nicola Papale <[email protected]>
Addresses:
$ cargo build --release --example lighting --target wasm32-unknown-unknown --features webgl error: none of the selected packages contains these features: webgl, did you mean: webgl2, webp?
Objective
./target/wasm_example.js
, since it didn't appear ongit grep
(missing extension)Solution