-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add READMEs to all crates and clarify they are part of Bevy #9995
Conversation
- Clarify that they are components of the BevyEngine. - Emphasize that they are not intended for independent use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little more color about what each crate does wouldn't hurt, but I think this is an improvement.
A readme for each crate is definitely an improvement. I'm approving that PR, but I'd like to nitpick on potential problems: modular designWe should make sure the wording
is not too strong for a few crates? As From my understanding, the crates listed seem to be indeed not thought out for independent use (yet ?) 👍. Trust authority
I agree it's a good information to share, but it might be a dangerous information to have in readme, because it teaches users to rely on readme information, where a malicious user could create a fake Readme saying their crate is part of bevy organisation and then do bad things™️ (phishing, malicious packages...). Footnotes |
@Vrixyz Bevy AppBevy App is a component of the Bevy Engine. You can revise the list of official crates here. This crate is intended to be used as a part of Bevy and not independently. However, feel free to use it if it fits your needs. |
"and then do bad things™️ (phishing, malicious packages...)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"revise" needs to change to "review". This is better boilerplate otherwise though!
Indicate bevy crate
I think linking to the GitHub repo for the list of crates is wrong. To have a good list, we could add a GitHub group to the authorised publishers on crates.io, then we could link to it. A team named official would have a link like |
@mockersf Oh, that would be great, but I think Cart is the only one with the permissions. For now, I believe linking to the GitHub repo is a good temporary solution. Or should I change the link to https://crates.io/users/cart ? |
let's try and see if we can get that team created and added as a publisher 👍 |
we now have https://crates.io/teams/github:bevyengine:publish as an owner of the crates on crates.io 🎉 |
Objective
The majority of the Bevy crates don't have a README.md.
I want to add a README so that when search for a crate on crates.io, it reports that: