Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more UT + remove nonsense UT #61

Merged
merged 3 commits into from
Feb 7, 2021
Merged

Add more UT + remove nonsense UT #61

merged 3 commits into from
Feb 7, 2021

Conversation

kornys
Copy link
Contributor

@kornys kornys commented Feb 5, 2021 •
edited
Loading

  1. Fix issues with surefire/failsafe profiles - every module set surefire and failsafe to set it properly becasue of quarkus and non quarkus modules
  2. Removed nonsense unit test and added unit tests for conditionutils, KafkaCluster and Canary
  3. Removed unused mock kubernetes server (We still use quarkusmmockkubernetes server until Support KubernetesServer test resource for CRUD operations quarkusio/quarkus#14821 will be merged)
  4. There are disabled tests because issue with ManagedKafkaBuilder [ManagedKafka builder failed when .build() method is called #60]
  5. Resolved quarkus warning about private Inject members -> remove private and keep package private as quarkus suggested.

@kornys kornys added the test Test related changes label Feb 5, 2021
@kornys kornys requested a review from ppatierno February 5, 2021 13:32
@kornys kornys self-assigned this Feb 5, 2021
@kornys kornys force-pushed the update-unit-tests branch from a00b31a to f0a2de1 Compare February 5, 2021 13:34
@kornys kornys changed the title Add more UT + remove nonsense UT [DRAFT] Add more UT + remove nonsense UT Feb 5, 2021
@kornys kornys force-pushed the update-unit-tests branch 2 times, most recently from afbe1c7 to 7424afe Compare February 5, 2021 13:39
@kornys kornys changed the title [DRAFT] Add more UT + remove nonsense UT Add more UT + remove nonsense UT Feb 5, 2021
@kornys kornys force-pushed the update-unit-tests branch from 5fbe69b to 706ec72 Compare February 7, 2021 18:29
@kornys kornys requested a review from ppatierno February 7, 2021 18:29
@ppatierno ppatierno merged commit 46d045d into bf2fc6cc711aee1a0c2a:main Feb 7, 2021
@ppatierno ppatierno deleted the update-unit-tests branch February 7, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppatierno ppatierno ppatierno approved these changes

Assignees

@kornys kornys

Labels
test Test related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kornys @ppatierno