Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.28.0 "// lintignore" regression #251

Closed
armsnyder opened this issue Jan 28, 2022 · 4 comments · Fixed by #252
Closed

v0.28.0 "// lintignore" regression #251

armsnyder opened this issue Jan 28, 2022 · 4 comments · Fixed by #252
Assignees
Labels
ast AST Handling bug Something isn't working
Milestone

Comments

@armsnyder
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

tfproviderlint Version

$ tfproviderlint -version
v0.28.0

Affected Check(s) or Function(s)

Affects the lintignore comment pass.

Expected Behavior

Expected existing // lintignore: XXXXX // my description comments (with a leading space and description) to function correctly and ignore issues on the subsequent lint after upgrading from v0.27.1 to v0.28.0

Actual Behavior

// lintignore: XXXXX // my description comments no longer suppress issues.

@armsnyder
Copy link
Contributor Author

I can take a look at this.

@bflad
Copy link
Owner

bflad commented Feb 4, 2022

For what its worth, Go comment directives should not contain the space by convention: golang/go#43776

However since the previous comment ignore logic was automatically stripping the spaces prior to v0.28.0, I guess we should still support the syntax.

@bflad bflad added ast AST Handling bug Something isn't working labels Feb 4, 2022
@bflad bflad added this to the v0.28.1 milestone Feb 4, 2022
@bflad bflad self-assigned this Feb 4, 2022
@bflad bflad closed this as completed in #252 Feb 4, 2022
@armsnyder
Copy link
Contributor Author

Thanks for the context re: directives 👍

@bflad
Copy link
Owner

bflad commented Feb 4, 2022

v0.28.1 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast AST Handling bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants