Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Analyzer: CRUD Function Declaration (crudfunc) #41

Closed
bflad opened this issue Jan 13, 2020 · 0 comments · Fixed by #102
Closed

New Analyzer: CRUD Function Declaration (crudfunc) #41

bflad opened this issue Jan 13, 2020 · 0 comments · Fixed by #102
Labels
ast AST Handling check/resource Resource Check new-analyzer New Analyzer for further checks

Comments

@bflad
Copy link
Owner

bflad commented Jan 13, 2020

Description

To support future checks in tfproviderlint and downstream provider linters, provide an Analyzer which returns all FuncDecl matching the signatures of the helper/schema CreateFunc, DeleteFunc, ReadFunc, and UpdateFunc types (func(*ResourceData, interface{}) error).

For now it can directly return the FuncDecl.
@bflad bflad added enhancement New feature or request ast AST Handling check/resource Resource Check new-analyzer New Analyzer for further checks and removed enhancement New feature or request labels Jan 13, 2020
bflad added a commit that referenced this issue Feb 18, 2020
@bflad
New Check: R014: check for CreateFunc, DeleteFunc, ReadFunc, and Upda…
c210774 
…teFunc parameter naming

Reference: #12
Reference: #41

Includes small breaking change to `NewSchemaValidationFuncInfo` parameters to simplify usage.
@bflad bflad mentioned this issue Feb 18, 2020
Merged
bflad added a commit that referenced this issue Feb 18, 2020
@bflad
New Check: R014: check for CreateFunc, DeleteFunc, ReadFunc, and Upda…
4fa91e3 
…teFunc parameter naming (#102)

Reference: #12
Reference: #41

Includes small breaking change to `NewSchemaValidationFuncInfo` parameters to simplify usage.
Mikechoi78 added a commit to Mikechoi78/tfproviderlint that referenced this issue May 23, 2022
@Mikechoi78
New Check: R014: check for CreateFunc, DeleteFunc, ReadFunc, and Upda…
e19023a 
…teFunc parameter naming (#102)

Reference: bflad/tfproviderlint#12
Reference: bflad/tfproviderlint#41

Includes small breaking change to `NewSchemaValidationFuncInfo` parameters to simplify usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ast AST Handling check/resource Resource Check new-analyzer New Analyzer for further checks
Projects
None yet
Milestone
No milestone
1 participant
@bflad