feat: allow renounce of delegation #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyzia551
previously approved these changes
Aug 30, 2022
|
I think renouncing functions should be symmetrical with giving delegation, so we need a |
|
Agree
Best regards,
Andrei
…On Tue, 30 Aug 2022, 16:48 Ernesto Boado, ***@***.***> wrote:
I think renouncing functions should be symmetrical with giving delegation,
so we need a renounceDelegation() renouncing both I think
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFXTWV5667MQUBA7RQTO6TV3YNLVANCNFSM6AAAAAAQANFDDE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
kyzia551
reviewed
Aug 31, 2022
| _balances[delegator], | ||
| GovernancePowerType.PROPOSITION | ||
| ); | ||
| require(votingDelegatee == msg.sender || propositionDelegatee == msg.sender, 'NO_DELEGATION'); |
There was a problem hiding this comment.
@eboadom "or" or "and", interesting question
There was a problem hiding this comment.
AND of course. OR is a bug
There was a problem hiding this comment.
Why though?
I perceived this to be the lazy function a la renounce Whatever, why would i fail if i only had one delegation?
Seems like a waste of gas to revert as it's clear that the user wanted to renounce.
There was a problem hiding this comment.
Ah, that is another way of seeing it yes. I think if documented, makes sense, don't see where it could be a problem to have OR behaviour
Quite polite 😄 |
|
It sounds legit, because the power of a guy will be renounced, even if he
delegated you half
…On Wed, 31 Aug 2022, 19:29 Lukas, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/AaveTokenV3.sol
<#6 (comment)>:
> _delegateByType(delegator, delegator, delegationType);
}
+
+ /// @inheritdoc IGovernancePowerDelegationToken
+ function renounceDelegator(address delegator) external override {
+ address votingDelegatee = _getDelegateeByType(
+ delegator,
+ _balances[delegator],
+ GovernancePowerType.VOTING
+ );
+ address propositionDelegatee = _getDelegateeByType(
+ delegator,
+ _balances[delegator],
+ GovernancePowerType.PROPOSITION
+ );
+ require(votingDelegatee == msg.sender || propositionDelegatee == msg.sender, 'NO_DELEGATION');
Why though?
I perceived this to be the lazy function a la renounce Whatever, why
would i fail if i only had one delegation?
Seems like a waste of gas as it's clear that the user wanted to renounce.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFXTWWAHPFLBWAW4H53TZ3V36I6DANCNFSM6AAAAAAQANFDDE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.