Skip to content

Commit

Permalink
Merge pull request #2085 from bgoonz/restyled/cms/blog/5-tips-for-bet…
Browse files Browse the repository at this point in the history
…ter-pull-requests
  • Loading branch information
bgoonz authored May 5, 2022
2 parents 7813725 + faa0b46 commit e193133
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/pages/blog/5-tips-for-better-pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ image_position: right
show_author_bio: true
cmseditable: true
---

<!--StartFragment-->

# 5 tips for better Pull Requests
Expand All @@ -22,4 +23,4 @@ Writing good code is only part of the job. Here are 5 tips to improve your pull
4. Review it yourself Before submitting your pull request for review, always take the time to review it yourself. That way you can handle some low-hanging fruits (typos, easy optimizations, leftover code etc.) and check things you would in other people’s pull requests. Self-reviewing has the added benefit of allowing you to reason about decisions and realize which ones might need clarification.
5. Respond to reviews Set some time aside to respond to reviews after submitting your pull request. Handle anything you can as soon as possible and start discussion whenever necessary to arrive to a solution. Use `--fixup` for changes suggested in review comments or add new commits to help reviewers parse new changes more easily. Finally, assume good intentions, be polite and thank your peers.

<!--EndFragment-->
<!--EndFragment-->

0 comments on commit e193133

Please sign in to comment.