Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1178 from bgoonz/master #1179

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Merge pull request #1178 from bgoonz/master #1179

merged 1 commit into from
Nov 27, 2021

Conversation

bgoonz
Copy link
Owner

@bgoonz bgoonz commented Nov 27, 2021

updates

@viezly
Copy link

viezly bot commented Nov 27, 2021

Empty pull request. No need to analyze

@vercel
Copy link

vercel bot commented Nov 27, 2021

Deployment failed with the following error:

Resource is limited - try again after in 3 hours (more than 100, code: "api-deployments-free-per-day").

@bgoonz bgoonz merged commit 924d1e0 into master Nov 27, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 27, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 25.66 😞 25.66 😞 0.00
Method Length 106.40 🙂 106.40 🙂 0.00
Working memory 14.05 😞 14.05 😞 0.00
Quality 33.57% 😞 33.57% 😞 0.00%
Other metrics Before After Change
Lines 397 397 0
Changed files Quality Before Quality After Quality Change
notes/dirhtml.py 33.57% 😞 33.57% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
notes/dirhtml.py process_dir 34 ⛔ 339 ⛔ 17 ⛔ 16.48% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant