Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyled by prettier-markdown #2085

Merged
merged 1 commit into from
May 5, 2022
Merged

Restyled by prettier-markdown #2085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/blog/5-tips-for-better-pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ image_position: right
show_author_bio: true
cmseditable: true
---

<!--StartFragment-->

# 5 tips for better Pull Requests
Expand All @@ -22,4 +23,4 @@ Writing good code is only part of the job. Here are 5 tips to improve your pull
4. Review it yourself Before submitting your pull request for review, always take the time to review it yourself. That way you can handle some low-hanging fruits (typos, easy optimizations, leftover code etc.) and check things you would in other people’s pull requests. Self-reviewing has the added benefit of allowing you to reason about decisions and realize which ones might need clarification.
5. Respond to reviews Set some time aside to respond to reviews after submitting your pull request. Handle anything you can as soon as possible and start discussion whenever necessary to arrive to a solution. Use `--fixup` for changes suggested in review comments or add new commits to help reviewers parse new changes more easily. Finally, assume good intentions, be polite and thank your peers.

<!--EndFragment-->
<!--EndFragment-->