-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default prometheus port #22
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animation created by Natasha Allegri
Utilize "VRP" terminology instead of "ROA" to be more concise.
Use the correct url in prometheus label
Adds `Last-Modified` header support and enables this (and `ETag`s) by default for rtrmon. I'm using rtrmon with a backend that suports `If-Modified-Since` but not `If-None-Match`. To poll this often (sub-minute interval) it is better to use conditional requests.
Add last modified support
* Track when the VRP was first seen for each VRP * Add a metric which tracks how many objects that were first seen [duration] ago are not present in the other endpoint. * Use current naming convention for the metric to be consistent (i.e. no prefix with application name).
* Visibility thresholds can be overridden via command line arguments. * Format the default thresholds in help output
This solves #2
* Add GitHub Actions build for docker image on docker hub. * Creates `rpki/stayrtr`, `rpki/rtrmon`, and `rpki/rtrdump` images (not all repositories exist at the moment).
Track objects that differ for a longer period separately
Str to int
If they are disabled the wrong way (e.g. `-log.verbose false -loglevel debug`) some of the arguments are eaten and later arguments no longer apply.
Clarify how boolean options are disabled in the help text.
Before this commit the new stayrtr state was only recalculated when the validated cache changed. This commit refactors the update loop and separates the actual update from pulling the updated cache. The update is triggered when the SLURM file changes _or_ when the validated cache changes. Should fix cloudflare/gortr#95 and make further changes that trigger an update when an update in the cache has expired easier.
Refactor to update state when cache or SLURM changes
…args Abort when positional arguments are provided
As suggested in #10, a port was 'claimed' at https://github.com/prometheus/prometheus/wiki/Default-port-allocations
Two daemons on the same port may be a bit annoying - I claimed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #10 , a port was 'claimed' at
https://github.com/prometheus/prometheus/wiki/Default-port-allocations