Fix for complex applications. Uncaught TypeError: Cannot convert object to primitive value.

[a904guy]

Fixes Uncaught TypeError: Cannot convert object to primitive value found when executed on http://www.linkedIn.com/pulse/
Just let chrome handle return, it will result in the same outcome.

Expected Outcome (after fix):

Error encountered:

[a904guy]

@bgrins, 👍 ?

Simple fix really, allows working with more complex JavaScript frameworks.

[bgrins]

I don't see the error when running the snippet on http://www.linkedIn.com/pulse/. I'm surprised that calling console.log was throwing an exception.. was this on canary?

[a904guy]

Standard release. 47.0.2526.106 (64-bit) Linux, and Windows for me.

[a904guy]

Will have to check to Windows version but considering they self update, I doubt it's much different.

[a904guy]

Version 47.0.2526.106 m for Windows.

[a904guy]

Using return

[bgrins]

This seems like a bug in chrome - I don't think console.log should ever throw. Do you have any extensions installed / do you see it on a clean profile? I'm just hesitant to land it because we have lots of other snippets that do console.log and if it's failing in certain cases this might bite all of them.

[a904guy]

I'll have to check but considering the call stack it looks like it may just
be LinkedIn is binding to it and causing the issue (at eye glance didn't
dig deep into the "un-uglified" code), regardless, it is unnecessary code
for the snippet.

On Mon, Mar 21, 2016, 1:29 PM Brian Grinstead [email protected]
wrote:

This seems like a bug in chrome - I don't think console.log should ever
throw. Do you have any extensions installed / do you see it on a clean
profile? I'm just hesitant to land it because we have lots of other
snippets that do console.log and if it's failing in certain cases this
might bite all of them.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#69 (comment)

[bgrins]

it looks like it may just be LinkedIn is binding to it and causing the issue

Could be. Indeed, console is replaceable as per the spec: whatwg/console#1 (at least for now) so a page could do console.log = function() { throwSomething() }.

[bgrins]

Going to close this out since it sounds like that page is doing something weird, but thanks for filing and talking it out

[a904guy]

I would still merge the modification, it works even if people tamper with console. So it is a better implementation. No?

[a904guy]

It is obviously being overwritten by the error call stack, my point still stands, removing console.log improves the success rate of using the script, with the exact same outcome.