Skip to content

Commit

Permalink
moved neck bend to bottom assembly to avoid issues with cadquery
Browse files Browse the repository at this point in the history
  • Loading branch information
bat52 committed Nov 4, 2024
1 parent bc8682f commit ce5c4cc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
9 changes: 9 additions & 0 deletions pylele2/pylele_bottom_assembly.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from pylele2.pylele_tuners import LeleTuners
from pylele2.pylele_fretboard_assembly import pylele_fretboard_assembly_parser
from pylele2.pylele_worm import pylele_worm_parser
from pylele2.pylele_neck_bend import LeleNeckBend


class LeleBottomAssembly(LeleBase):
Expand Down Expand Up @@ -54,6 +55,14 @@ def gen(self) -> Shape:
body -= LeleNeckJoint(cli=self.cli, isCut=True)\
.mv(-self.api.getJoinCutTol(), 0, self.api.getJoinCutTol())

## Neck Bend
if self.cli.body_type in [
LeleBodyType.FLAT,
LeleBodyType.HOLLOW,
LeleBodyType.TRAVEL
]:
body += LeleNeckBend(cli=self.cli)

## Fretboard Spines
if (self.cli.separate_fretboard or
self.cli.separate_neck or
Expand Down
6 changes: 4 additions & 2 deletions pylele2/pylele_neck_assembly.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from pylele2.pylele_head import LeleHead
from pylele2.pylele_neck_joint import LeleNeckJoint
from pylele2.pylele_neck import LeleNeck
from pylele2.pylele_neck_bend import LeleNeckBend
# from pylele2.pylele_neck_bend import LeleNeckBend
from pylele2.pylele_spines import LeleSpines

class LeleNeckAssembly(LeleBase):
Expand Down Expand Up @@ -58,14 +58,16 @@ def gen(self) -> Shape:
## Spines
if self.cli.num_spines > 0:
neck -= LeleSpines(cli=self.cli, isCut=True).mv(0, 0, self.api.getJoinCutTol())


"""
## Neck Bend
if self.cli.body_type in [
LeleBodyType.FLAT,
LeleBodyType.HOLLOW,
LeleBodyType.TRAVEL
]:
neck += LeleNeckBend(cli=self.cli)
"""

## Fretboard Spines
if (self.cli.separate_fretboard or self.cli.separate_top or self.cli.separate_neck) and self.cli.num_spines > 0:
Expand Down

0 comments on commit ce5c4cc

Please sign in to comment.