Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expound providing clojurescript? #16

Closed
olivergeorge opened this issue Aug 16, 2017 · 10 comments
Closed

Expound providing clojurescript? #16

olivergeorge opened this issue Aug 16, 2017 · 10 comments

Comments

@olivergeorge
Copy link

Something in the expound's configuration causes Cursive to have trouble resolving functions cleanly. I'm not sure why this happens.

image

@bhb
Copy link
Owner

bhb commented Aug 16, 2017

Thanks for reporting this!

It looks like it's a known Cursive bug but it does not appear to happen with all .cljc files (for instance, I could not reproduce it with Integrant).

I'll look into this more. If there is something I can change in the project.clj file that fixes this without breaking other scenarios, I'm happy to try it.

@danielcompton
Copy link

danielcompton commented Aug 16, 2017

screenshot of finder 16-08-17 1-37-03 pm

I think this is because the jar includes compiled test files in it? https://repo.clojars.org/expound/expound/

@bhb
Copy link
Owner

bhb commented Aug 16, 2017

@danielcompton Thanks very much for the idea! That does indeed look suspicious. I'll look into how to exclude this directory when doing lein deploy clojars

@danielcompton
Copy link

Because they are in resources/public this would be included by default. You can use :jar-exclusions, or maybe compile the CLJS into a different directory?

@bhb
Copy link
Owner

bhb commented Aug 16, 2017

@danielcompton Hm, I'm considering my options here. I put everything in resources originally so that I could connect to Figwheel in the browser to access a CLJS REPL, but it does seem cleaner to compile all CLJS for tests in, say target.

OTOH, just using :jar-exclusions would fix this for now, even if it's a bit of a hacky workaround

@bhb
Copy link
Owner

bhb commented Aug 16, 2017

@danielcompton I can confirm that excluding these files from the jar fixes the issue. Thanks very much for the idea, that would not have occurred to me!

I'll weigh my options and figure out a good fix for this ASAP.

@bhb
Copy link
Owner

bhb commented Aug 16, 2017

@olivergeorge OK, I think I've got a simple fix for this. I think eventually I'll take @danielcompton's suggestion to reconfigure the project to not put compiled JS in resources, but for now, I've updated the :clean-targets option in project.clj.

Would you mind confirming the fix?

  1. git clone [email protected]:bhb/expound.git
  2. cd expound
  3. git checkout cursive-bug
  4. lein install
  5. In your test project, include [expound "0.2.1-SNAPSHOT"]

@olivergeorge
Copy link
Author

@bhb Confirmed. 0.2.1-SNAPSHOT resolves the problem.

@bhb
Copy link
Owner

bhb commented Aug 16, 2017

@olivergeorge Thanks for testing!

@bhb bhb closed this as completed in #17 Aug 16, 2017
@bhb
Copy link
Owner

bhb commented Aug 16, 2017

I've released 0.2.1 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants