-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLJC completions are 'ambiguous' #1132
Comments
I wonder if *puts on architect hat* there should be three modes that Cursive can be resolving in: clj, cljs, and cljc. When in a cljc file and not in a reader conditional block, then it would be in cljc mode, and resolve all other vars reachable in cljc mode. When in a cljs reader conditional block inside a cljc file, it would be in cljs mode, and only resolve cljs or cljc vars. |
@danielcompton That's more or less what I'm planning to do, but it's somewhat trickier than that. But that's my intention, yes. |
Any updates to this issue? Cursive still shows all cljc namespaces twice in the navigation. |
Cursive's CLJC support doesn't identify that symbols defined and used in CLJC files resolve to the same source file, so it offers two possible resolutions. This causes Quick Help and Parameters intentions to fail, and cause Jump to Definition to show a popup, as shown above.
Cursive should be able to identify that the symbols resolve to the same source location via two different routes, and over a single completion.
(Example uses
schema.core
, fromprismatic/schema
)The text was updated successfully, but these errors were encountered: