Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLJC completions are 'ambiguous' #1132

Open
sfnelson opened this issue Nov 2, 2015 · 4 comments
Open

CLJC completions are 'ambiguous' #1132

sfnelson opened this issue Nov 2, 2015 · 4 comments

Comments

@sfnelson
Copy link

sfnelson commented Nov 2, 2015

screen shot 2015-11-02 at 4 10 09 pm

Cursive's CLJC support doesn't identify that symbols defined and used in CLJC files resolve to the same source file, so it offers two possible resolutions. This causes Quick Help and Parameters intentions to fail, and cause Jump to Definition to show a popup, as shown above.

Cursive should be able to identify that the symbols resolve to the same source location via two different routes, and over a single completion.

(Example uses schema.core, from prismatic/schema)

@danielcompton
Copy link
Collaborator

danielcompton commented May 18, 2016

I wonder if *puts on architect hat* there should be three modes that Cursive can be resolving in: clj, cljs, and cljc. When in a cljc file and not in a reader conditional block, then it would be in cljc mode, and resolve all other vars reachable in cljc mode. When in a cljs reader conditional block inside a cljc file, it would be in cljs mode, and only resolve cljs or cljc vars.

@danielcompton
Copy link
Collaborator

This also shows up when jumping to a namespace:

screenshot of intellij idea 19-05-16 9-53-54 am

@cursive-ide
Copy link
Owner

@danielcompton That's more or less what I'm planning to do, but it's somewhat trickier than that. But that's my intention, yes.

@katox
Copy link

katox commented Apr 3, 2020

Any updates to this issue? Cursive still shows all cljc namespaces twice in the navigation.

@cursive-ide cursive-ide removed the CLJC label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants