Mirror PRs from Robocop: 1137, 1147, 1153 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's fine, I see why it's necessary ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored following PRs (together with PR with fixes to them):
MarketSquare/robotframework-robocop#1137
MarketSquare/robotframework-robocop#1147
MarketSquare/robotframework-robocop#1153
It's not complete copy paste - I have adjusted rules to new Robocop format. I did not change rule ids / documentation hovewer, it will be done in the separate PR. Possibly I will move them together to another file later on as well (misc.py is getting too long).
@Lakitna I apologise for just 'copying' your PRs, but I'm in the middle of developing new Robocop and it's done in the separate repository. At the end I will rename this repository to 'robocop' one, while current robocop will became 'deprecated-robocop'. It may be confusing at first, but it was necessary in order to complete merge of both tools. I will link all details to original authors / repos later on.