Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superhero-Search-Project #3

Merged
merged 9 commits into from
Oct 14, 2023
Merged

Superhero-Search-Project #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4710265
Add LICENSE file
Oct 14, 2023
04b2325
Use less than 2 warm colour
Oct 14, 2023
8e6e44c
Cretae new folder for test file
Oct 14, 2023
109d995
Readme file changes , linters fix
Oct 14, 2023
fa97ba7
linters fix
Oct 14, 2023
7f659ff
Deployment changes
Oct 14, 2023
6468cdb
changes
Oct 14, 2023
6551729
Add presentaation video
Oct 14, 2023
e3eb9ba
changes
Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 4 additions & 118 deletions LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,121 +1,7 @@
<a name="readme-top"></a>
<div align="center">
<h3><b>Superhero-Search-Website</b></h3>
</div>
## Copyright 2023, [Bhushan Deshmukh]

# 📗 Table of Contents
Permission is hereby granted, free of charge, to any person obtaining a copy of this [Portfolio] and associated documentation files, to deal in the [Portfolio] without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the [Portfolio], and to permit persons to whom the [Portfolio] is furnished to do so, subject to the following conditions:

- [📗 Table of Contents](#-table-of-contents)
- [🛠 Built With ](#-built-with-)
- [Tech Stack ](#tech-stack-)
- [Key Features ](#key-features-)
- [🚀 Live Demo ](#-live-demo-)
- [🚀 Project presentation ](#-project-presentation-)
- [💻 Getting Started ](#-getting-started-)
- [Prerequisites](#prerequisites)
- [👥 Authors ](#-authors-)
- [🔭 Future Features ](#-future-features-)
- [🤝 Contributing ](#-contributing-)
- [⭐️ Show your support ](#️-show-your-support-)
- [🙏 Acknowledgments ](#-acknowledgments-)
- [📝 License ](#-license-)
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the [Portfolio].


**[A&B films]** shows list of popular Rockets<br />

## 🛠 Built With <a name="built-with"></a>

### Tech Stack <a name="tech-stack"></a>
- HTML
- CSS
- React
- Redux-toolkit
- WEBPACK
- Marvel-API

### Key Features <a name="key-features"></a>

- When You Search you will see the searched results filtered .
- Used react-router to naviggate through pages.

<p align="right">(<a href="#readme-top">back to top</a>)</p>

## 🚀 Live Demo <a name="live-demo"></a>

- [[Live Demo link](https://bhushan354.github.io/Superhero-Search-Project/)]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I noticed that your live link is not working, rather it shows your actual live web app, it just shows your README file, which is totally unprofessional, irrelevant and not acceptable as per the requirement. Kindly deploy your project properly and share the correct deployed link in the README file.

image

Copy link

@Whoistolu Whoistolu Oct 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [REQUIRED] This project is still yet to be deployed as recommended by the previous reviewer and as stated by the project requirement. Kindly deploy your project properly and share the correct deployed link in the README file. Kindly deploy your project properly and add the deployment link here.


<p align="right">(<a href="#readme-top">back to top</a>)</p>

## 🚀 Project presentation <a name="live-demo"></a>

- [Project presentation link](will add later)

<p align="right">(<a href="#readme-top">back to top</a>)</p>

## 💻 Getting Started <a name="getting-started"></a>

To get a local copy up and running, follow these steps.

### Prerequisites
- Browser
- Node
- Code Editor

In order to run this project you need:

To get a local copy up and running follow these simple example steps.

- Choose a directory
- Open a Terminal
- write: git clone [email protected]:bhushan354/Superhero-Search-Project.git
- get into to directory
- write: npm install
- then write: npm start

<p align="right">(<a href="#readme-top">back to top</a>)</p>

## 👥 Authors <a name="authors"></a>

👤 **Bhushan Deshmukh**
- GitHub: [@bhushan](https://github.com/bhushan354)
- Twitter: [@bhushan](https://twitter.com/Bhushan_4885)


<p align="right">(<a href="#readme-top">back to top</a>)</p>



## 🔭 Future Features <a name="future-features"></a>

- [ ] **[Complete all the sections using different Api]**

<p align="right">(<a href="#readme-top">back to top</a>)</p>


## 🤝 Contributing <a name="contributing"></a>

Contributions, issues, and feature requests are welcome!

Feel free to check the [issues page](https://github.com/bhushan354//issues)

Comment on lines -96 to -100
Copy link

@skyv26 skyv26 Oct 14, 2023 •
edited by bhushan354
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please make sure that you don't have any broken links in your README file because I tried to see your contributing link which is supposed to take me to your repo issue section, but I got a 404 page which means the path that you provided in your README file is not correct, kindly fix it.

image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • well resolved

<p align="right">(<a href="#readme-top">back to top</a>)</p>


## ⭐️ Show your support <a name="support"></a>

If you like this project, pplease, feel free to star the repository and share it with others who might benefit from it.

<p align="right">(<a href="#readme-top">back to top</a>)</p>

<p align="right">(<a href="#readme-top">back to top</a>)</p>

## 🙏 Acknowledgments <a name="acknowledgements"></a>

I would like to thank the Microverse team and Code reviewers who helped us create this project. Also, I would like to express our sincere gratitude to [Agustine Soria](https://github.com/SaveryIV) for his valuable assistance in solving a problem with fetching rockets From API. His expertise and guidance Ire instrumental in finding a solution.
Comment on lines -112 to -114
Copy link

@skyv26 skyv26 Oct 14, 2023 •
edited by bhushan354
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Well done, I really appreciate your sincerity in acknowledging your peer/fellow/friend who helped you with the project but as per the requirement, you should acknowledge first the designer of the web application from whom you took the inspiration to design the application. Please follow the requirements carefully and update this section with acknowledgement for the designer of the metrics apps.

image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • well resolved



## 📝 License <a name="license"></a>

This project is [MIT](./LICENSE) licensed.

<p align="right">(<a href="#readme-top">back to top</a>)</p>
THE [Portfolio] IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE [Portfolio] OR THE USE OR OTHER DEALINGS IN THE [Portfolio].
10 changes: 4 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
- [📝 License ](#-license-)


**[A&B films]** shows list of popular Rockets<br />

## 🛠 Built With <a name="built-with"></a>

### Tech Stack <a name="tech-stack"></a>
Expand All @@ -48,7 +46,7 @@

## 🚀 Project presentation <a name="live-demo"></a>

- [Project presentation link](will add later)
- [Project presentation link](https://drive.google.com/file/d/1DLrnDYy-_wef153-CCEMP3wsz0uk5aqB/view?usp=sharing)

<p align="right">(<a href="#readme-top">back to top</a>)</p>

Expand Down Expand Up @@ -96,7 +94,7 @@ To get a local copy up and running follow these simple example steps.

Contributions, issues, and feature requests are welcome!

Feel free to check the [issues page](https://github.com/bhushan354//issues)
Feel free to check the [issues page](https://github.com/bhushan354/Superhero-Search-Project/issues)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Well resolved


<p align="right">(<a href="#readme-top">back to top</a>)</p>

Expand All @@ -111,11 +109,11 @@ If you like this project, pplease, feel free to star the repository and share it

## 🙏 Acknowledgments <a name="acknowledgements"></a>

I would like to thank the Microverse team and Code reviewers who helped us create this project. Also, I would like to express our sincere gratitude to [Agustine Soria](https://github.com/SaveryIV) for his valuable assistance in solving a problem with fetching Superheor data From API. His expertise and guidance helped me in finding a solution.
I would like to thank the Nelson Sakwa from him I took Inspiration to build this project and Microverse team and Code reviewers who helped us create this project. Also, I would like to express our sincere gratitude to [Agustine Soria](https://github.com/SaveryIV) for his valuable assistance in solving a problem with fetching Superheor data From API. His expertise and guidance helped me in finding a solution.


## 📝 License <a name="license"></a>

This project is [MIT](./MIT) licensed.
This project is [MIT](./LICENSE) licensed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Well resolved


<p align="right">(<a href="#readme-top">back to top</a>)</p>
Loading