-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP 020 Eye Tracking #1128
base: master
Are you sure you want to change the base?
Conversation
correction of text
(NOTE: I'll cross-post this message across several BEP threads) Hi there, just a quick notification that we have just merged #918 and it may be interesting to look at the implications for this BEP. We are introducing "BIDS URIs", which unify the way we refer to and point to files in BIDS datasets (as opposed to "dataset-relative" or "subject-relative" or "file-relative" links). If the diff and discussion in the PR is unclear, you can also read the rendered version: https://bids-specification.readthedocs.io/en/latest/02-common-principles.html#bids-uri Perhaps there are things in the BEP that need adjusting now, but perhaps also not -- in any case it's good to be aware of this new feature! Let me know if there are any questions, comments, or concerns. |
Not yet! Please fill out to find a time for the next meeting: https://doodle.com/meeting/participate/id/b2OzP3jd. Times should be displayed in your time zone. I tried to choose times that are manageable in all the time zones. |
Coordinate system of the gaze position recordings. | ||
Generally eye-tracker are set to use `"gaze-on-screen"` coordinate system but you may use | ||
`"eye-in-head"` or `"gaze-in-world"` or other alternatives of your choice. | ||
If you use the standard `"gaze-on-screen"`, it is RECOMMENDED to use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this an enum and allow "custom" so the user can specify a system that is not captured by the enum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with it.
Co-authored-by: Scott Huberty <[email protected]>
StimulusPresentation_for_eyetracking: | ||
selectors: | ||
- suffix == "events" | ||
- intersects([suffix], ["eyetrack"]) | ||
fields: | ||
StimulusPresentation.ScreenDistance: required | ||
StimulusPresentation.ScreenOrigin: required | ||
StimulusPresentation.ScreenRefreshRate: recommended | ||
StimulusPresentation.ScreenResolution: required | ||
StimulusPresentation.ScreenSize: required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I can't see a comment where I would swear I followed up on this and asked @Remi-Gau to finalize this 👀
I also tagged @effigies, @tsalo and @rwblair for support about the schema.
I think I was proposing something of the sort of:
StimulusPresentation_for_eyetracking: | |
selectors: | |
- suffix == "events" | |
- intersects([suffix], ["eyetrack"]) | |
fields: | |
StimulusPresentation.ScreenDistance: required | |
StimulusPresentation.ScreenOrigin: required | |
StimulusPresentation.ScreenRefreshRate: recommended | |
StimulusPresentation.ScreenResolution: required | |
StimulusPresentation.ScreenSize: required | |
StimulusPresentation_for_eyetracking: | |
selectors: | |
- suffix == "events" | |
- (suffix == "physio").PhysioType == "eyetrack" | |
fields: | |
StimulusPresentation.ScreenDistance: required | |
StimulusPresentation.ScreenOrigin: required | |
StimulusPresentation.ScreenRefreshRate: recommended | |
StimulusPresentation.ScreenResolution: required | |
StimulusPresentation.ScreenSize: required |
The idea is that, for those events files matching tasks with physio files AND those physio files have the metadata PhysioType=eyetrack, then make these StimulusPresentation fields REQUIRED.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to bids-standard/bids-validator#143
for more information, see https://pre-commit.ci
Changing AverageCalibrationError and MaximalCalibrationError to use the term "degrees of visual angle" rather than "degrees" and "visual degrees".
for more information, see https://pre-commit.ci
Change EyeTrackingMethod to get rid of the citation of a retracted paper.
@mszinte (re: 77fd567) It'd probably best to point all the examples to the BIDS-Examples repo bids-standard/bids-examples#478. The main reason is that the BIDS-Examples PR is using our version of the schema (and therefore, the |
Here is the specifications of the BEP 020 about eye tracking.
Note
We meet regularly and everyone is welcome :
Next meeting January 23rd 2025 4pm UTC (EST 11am, PST 8am, CET 5pm, GMT 4pm) on zoom.
Note that if you consider joining but this time or day doesn't suits you, reach me (@mszinte) and I will arrange another appointment.
Notes of last meeting
Chat and discussions also happening on matrix
Tip
HTML preview of this BEP
Issues for: