[FIX] Run codespell 2.4.0 throughout fixing few left typos automagically #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
added
the
exclude-from-changelog
Those were detected with codespell 2.4.0 and indeed we had inconsistencies on GB vs US forms for "localization" so it is harmonized now.
effigies
force-pushed
the
bf-codespell2
branch
from
45641f3 to
2d517df
Compare
Co-authored-by: Dimitri Papadopoulos Orfanos <[email protected]>
DimitriPapadopoulos
requested changes
Jan 21, 2025
There was a problem hiding this comment.
- Don't need both
acknowledgementsandAcknowledgements. - Also
manuelhas been removed from the main dictionary (Ignore personal names Damon and Manuel codespell-project/codespell#3204).
DimitriPapadopoulos
approved these changes
Jan 21, 2025
effigies
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2033 +/- ##
=======================================
Coverage 82.45% 82.45%
=======================================
Files 17 17
Lines 1499 1499
=======================================
Hits 1236 1236
Misses 263 263 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI started to error out codespell as I saw in #2032 and it is due to new codespell 2.4.0.
So this PR fixes those detected with codespell 2.4.0 and indeed we had inconsistencies on GB vs US forms for "localization" so it is harmonized now.
I have done
HEPexclusion via regex which might slow things down but would keep it case specific