Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NODE-84, chore: web3_clientVersion response format #12

Merged
merged 3 commits into from
Jan 18, 2024
Merged

NODE-84, chore: web3_clientVersion response format #12

merged 3 commits into from
Jan 18, 2024

Conversation

alstjd0921
Copy link
Member

@alstjd0921 alstjd0921 commented Jan 17, 2024 •
edited
Loading

Description

  • Update web3_clientVersion's response format into geth style.
  • Before
    image
  • After
    image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Something else (simple changes that are not related to existing functionality or others)

Checklist

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have made new test codes regarding to my changes.
  • I have no personal secrets or credentials described on my changes.
  • I have run cargo-clippy and linted my code.
  • My changes generate no new warnings.
  • My changes passed the existing test codes.
  • My changes are able to compile.

@alstjd0921 alstjd0921 self-assigned this Jan 17, 2024
@dnjscksdn98
Copy link
Collaborator

bifrost-node 프로젝트 적용도 부탁드릴게요

@alstjd0921 alstjd0921 merged commit b265b1c into bifrost-polkadot-v1.3.0 Jan 18, 2024
@alstjd0921 alstjd0921 mentioned this pull request Jan 18, 2024
Merged
13 tasks
dnjscksdn98 pushed a commit that referenced this pull request Jul 22, 2024
@alstjd0921 @dnjscksdn98
NODE-84, chore: web3_clientVersion response format (#12)
d168a82 
* NODE-84, chore: web3_clientVersion response format

* NODE-84, fix: save rustc metadata at compile time

* NODE-84, fix: better build script
dnjscksdn98 pushed a commit that referenced this pull request Sep 23, 2024
@alstjd0921 @dnjscksdn98
NODE-84, chore: web3_clientVersion response format (#12)
75c58ad 
* NODE-84, chore: web3_clientVersion response format

* NODE-84, fix: save rustc metadata at compile time

* NODE-84, fix: better build script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnjscksdn98 dnjscksdn98 dnjscksdn98 approved these changes

@SunoukMun SunoukMun Awaiting requested review from SunoukMun

Assignees

@alstjd0921 alstjd0921

Labels
chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alstjd0921 @dnjscksdn98