Fix Button: make label prop optional #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shashank-bhatotia
commented
May 16, 2024
shashank-bhatotia
commented
- Fixes Fix Button: make the label as an optional prop #655
|
@paulsojan _a Please review. |
paulsojan
approved these changes
May 16, 2024
|
@sangameshsomawar _a Please review and merge |
sangameshsomawar
approved these changes
May 16, 2024
There was a problem hiding this comment.
@paulsojan @shashank-bhatotia : If we are using a button without a label, are we using it with an icon? If so, I think we need to adjust the margins when the label is empty. Otherwise, the icon might appear misaligned. Please check this scenario and merge.
|
@sangameshsomawar _a Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.