Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add poll shape to Tldraw #15

Closed
wants to merge 18 commits into from

Conversation

danielpetri1
Copy link

@danielpetri1 danielpetri1 commented Aug 30, 2024

When BigBlueButton displays a poll on the canvas, the client currently extends Tldraw with a custom shape. As a result, only the Tldraw instances tied to bbb-html5 profit from the functionality, despite other components, such as bbb-playback, bbb-export-annotations, and bbb-presentation-video needing to display such a poll.

This PR is a stepstone towards centralizing the poll shape directly in Tldraw, which would close the following issues:

Development plan

  1. Add the custom shape to the Tldraw fork

  2. Change BBB 3.0 core to include the poll shape data in tldraw.json for bbb-playback
    2.1. This automatically makes the new polls shapes appear in the recordings

  3. Remove duplicated custom shape from BBB's client, using the new implementation instead (we are here)

  4. Change Tldraw to include an image representation in the shape's meta parameter

  5. Use the poll image in the annotation export

  6. Use the poll image in the video

For the poll image, we can follow the same approach used by the slide snapshot: bigbluebutton/bigbluebutton#21005

Demo

tldraw.polls.mov

@danielpetri1
Copy link
Author

Closing in favor of #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants