-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): upgrade to latest lerna v8 and pnpm v9 #414
feat(repo): upgrade to latest lerna v8 and pnpm v9 #414
Conversation
@benpsnyder is attempting to deploy a commit to the Bigcapital Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, just pushed a commit just to make sure pnpm-lock.yaml
is up-to-date.
@all-contributors please add @benpsnyder for code. |
I've put up a pull request to add @benpsnyder! 🎉 |
@abouolia I believe what you did was revert from lockfileVersion: '9.0' to lockfileVersion: '6.0' because you're using an older version of PNPM than latest. There wasn't a perfect way to enforce the latest PNPM version in the repo so I didn't add that to the PR. |
I addressed this on my other PRs with the following in "engineStrict": true,
"engines": {
"node": "16.x || 17.x || 18.x || 20.x",
"pnpm": ">=9"
}, |
@benpsnyder I have fixed it, thanks for mentioning that. |
I've been using Nx for 5+ years and was excited to see them take over stewardship of Lerna. We should take advantage of the latest updates ... upgrading to latest Lerna and PNPM is easy and will add great performance and value to the project.
This is also done in #413 but I wanted to open a standalone PR for it.