-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CLI user experience & create continuity between control panel and CLI #1820
Conversation
🦋 Changeset detectedLatest commit: 7f665f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
a1bbc9c
to
3c451f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just want to make sure we are thinking about the .env file makeup.
|
||
if (this.config.auth?.storeHash && this.config.auth.accessToken) { | ||
configObj.auth = { | ||
storeHash: this.config.auth.storeHash, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the same store hash be in the main .env file and this config? If it is, do we need the store hash in both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The utility of the .catalyst
file is you can regenerate the .env.local, so it makes sense for it to have no dependencies on .env.local
a2b801f
to
8bb29d8
Compare
Appreciate the changes post review. Flow looks 🧈 |
8bb29d8
to
7f665f9
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-9sa5wispd-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
.catalyst
file with store hash/access token after login action to be used for other CLI commands without re-prompting for loginTesting
Create wizard (the extraneous log statement is not there in this actual PR)
createwizard.mov
Starting from app (I invalidated these credentials before posting this)
occ-to-cli.mov
Init command
init.mov