Merge pull request #1323 from bc-zoharmuzafi/amp-page-error

Amp page error
bigcommerce · Sep 7, 2018 · f19db83 · f19db83
2 parents 72e2cc7 + 32883ce
commit f19db83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Draft 
 - Fix encoding issues on Account Signup Form ("&#039;" characters showing in country name)[#1341] (https://github.com/bigcommerce/cornerstone/pull/1341)
 - Require Webpack config only when used (reduce time to be ready for receiving messages from stencil-cli). [#1334](https://github.com/bigcommerce/cornerstone/pull/1334)
+- Fixed amp page error related to store logo [#1323](https://github.com/bigcommerce/cornerstone/pull/1323)
 
 ## 2.3.2 (2018-08-17)
 - Fix zoom behavior for small images in gallery (turn off zoom if image is too small). [#1325](https://github.com/bigcommerce/cornerstone/pull/1325)

diff --git a/templates/components/amp/common/store-logo.html b/templates/components/amp/common/store-logo.html
@@ -7,8 +7,12 @@
             {{else}}
                 width="{{first (split theme_settings.logo_size 'x')}}"
                 height="{{last (split theme_settings.logo_size 'x')}}"
+                {{#if (last (split theme_settings.logo_size 'x')) 'gtnum' (first (split theme_settings.logo_size 'x')) }}
+                    sizes="(max-width: 360px) 100vw, 1vw"
+                {{else}}
+                    sizes="(max-width: 360px) 100vw, 10vw"
+                {{/if}}
                 layout="responsive"
-                sizes="(min-height: {{last (split theme_settings.logo_size 'x')}}%)"
             {{/if}}
             alt="{{settings.store_logo.title}}">
         </amp-img>