CRO-172 Ability to see product illustrations in the storefront when t… #1054
Conversation
|
you will need to add an entry under Draft in CHANGELOG.md. See example here https://github.com/bigcommerce/cornerstone/pull/1053/files |
|
Make sure this doesn't break solano integration tests |
CHANGELOG.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## Draft | |||
| - When a store has empty product inventory, we show a set of sample products on homepage. For sample products they has no URL and not clickable. They also don't have quick view. Check if it is sample product by id > 0. | |||
There was a problem hiding this comment.
You need to rebase your branch.
| @@ -16,14 +16,21 @@ | |||
| </div> | |||
| {{/if}} | |||
| {{/or}} | |||
| <a href="{{url}}"> | |||
| {{#if id '>' 0}} | |||
There was a problem hiding this comment.
Can you give some information what is this id & where is it coming from ?
There was a problem hiding this comment.
This id is product id which is the index key in product db table. id is a positive number and uniq for real products. For sample products we assign negative numbers to id.
On homepage, if there is no inventory products we display sample products with no URL and no Quick View.
CHANGELOG.md
Outdated
| @@ -3,6 +3,9 @@ | |||
| ## Draft | |||
| - Hide Info in footer if no address is provided in Store Profile. Hide Brands in footer if Merchant has no brands [#1053](https://github.com/bigcommerce/cornerstone/pull/1053) | |||
|
|
|||
| {{#if id '>' 0}} | ||
| <a href="{{url}}">{{name}}</a> | ||
| {{/if}} | ||
| {{#if id '<' 0 }} |
| @@ -16,14 +16,21 @@ | |||
| </div> | |||
| {{/if}} | |||
| {{/or}} | |||
| <a href="{{url}}"> | |||
| {{#if id '>' 0}} | |||
There was a problem hiding this comment.
I think you can omit the >
{{#if id}}...{{/if}}
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## Draft | |||
| - Hide Info in footer if no address is provided in Store Profile. Hide Brands in footer if Merchant has no brands [#1053](https://github.com/bigcommerce/cornerstone/pull/1053) | |||
| - When a store has empty product inventory, we show a set of sample products on homepage. For sample products they has no URL and not clickable. They also don't have quick view. Check if it is sample product by id > 0. | |||
There was a problem hiding this comment.
Can we remove this part For sample products they has no URL and not clickable. They also don't have quick view. Check if it is sample product by id > 0.. We should keep it simple & concise.
| <figcaption class="card-figcaption"> | ||
| <div class="card-figcaption-body"> | ||
| {{#unless hide_product_quick_view}} | ||
| {{#if theme_settings.show_product_quick_view}} | ||
| <a href="#" class="button button--small card-figcaption-button quickview" data-product-id="{{id}}">{{lang 'products.quick_view'}}</a> | ||
| {{#if demo '!==' true}} |
There was a problem hiding this comment.
Can we change this to unless demo
There was a problem hiding this comment.
See http://handlebarsjs.com/builtin_helpers.html for details.
…he product catalog is empty
|
💚 |
…he product catalog is empty
What?
Part of CRO-9. show demo products on product on Cornerstone theme home page when inventory is empty
When there is not inventory data in DB. we inject a data array in resource with negative product ids.
At Cornerstone side, when id is negative, we hide the URL and Quick View.
Tickets / Documentation
https://jira.bigcommerce.com/browse/CRO-172
https://launchbay.bigcommerce.net/projects/1/releases/36743
Screenshots (if appropriate)
@bigcommerce/cp-dt @mcampa @junedkazi