STRF-3860: Fixed Shop by Price visibility when toggle is disabled in … #1161
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| - Fix logo not loading on order confirmation page [#1159](https://github.com/bigcommerce/cornerstone/pull/1159) | |||
| - Add support in Cornerstone to consume AMP ID [#1155](https://github.com/bigcommerce/cornerstone/pull/1155) | |||
| - Fix option selection reset bug when a variation is out of stock [#1160](https://github.com/bigcommerce/cornerstone/pull/1160) | |||
| - Fix "Shop by Price" toggle in theme editor to hide Shop by Price when faceted search is not enabled. | |||
There was a problem hiding this comment.
You can add the PR link here now that it exists.
| @@ -55,7 +55,7 @@ | |||
| "productpage_related_products_count": 10, | |||
| "productpage_similar_by_views_count": 10, | |||
| "categorypage_products_per_page": 12, | |||
| "shop_by_price_visible": true, | |||
There was a problem hiding this comment.
I believe the existing configuration values for this field are saved in the TR DB, so renaming the field effectively wipes out all existing merchant settings, is that right?
There was a problem hiding this comment.
Thank you for pointing that out. I found a better way to implement the change without changing the TR DB value.
| @@ -24,16 +24,10 @@ <h1 class="page-heading">{{category.name}}</h1> | |||
| {{{category.description}}} | |||
| {{{snippet 'categories'}}} | |||
| <div class="page"> | |||
| {{#or category.subcategories category.faceted_search_enabled}} | |||
| {{#or category.subcategories category.faceted_search_enabled category.shop_by_price}} | |||
There was a problem hiding this comment.
This should probably be a simple if check now right? Since it's not like an or / else.
There was a problem hiding this comment.
This has always been an or statement as I ended up reverting the changes from 1036. I did try to change it to an if upon doing so though it did generate a 500 internal server error with stapler.
There was a problem hiding this comment.
Ah yeah that's my bad, I didn't understand what the or helper was actually doing.
|
👍this looks fine to me but I'll leave final approval to the STRF guys. |
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| - Fix logo not loading on order confirmation page [#1159](https://github.com/bigcommerce/cornerstone/pull/1159) | |||
| - Add support in Cornerstone to consume AMP ID [#1155](https://github.com/bigcommerce/cornerstone/pull/1155) | |||
| - Fix option selection reset bug when a variation is out of stock [#1160](https://github.com/bigcommerce/cornerstone/pull/1160) | |||
| - Fix "Shop by Price" toggle in theme editor to hide Shop by Price when faceted search is not enabled. [#1161](https://github.com/bigcommerce/cornerstone/pull/1161) | |||
There was a problem hiding this comment.
This entry should go in the draft section.
There was a problem hiding this comment.
Please rebase your branch.
There was a problem hiding this comment.
I was able to rebase and move the entry into the draft section @junedkazi .
adamdyche
force-pushed
the
STRF-3860
branch
2 times, most recently
from
983dda8 to
2cbd25f
Compare
… by price visibility and toggle
What?
Fixes the Show "Shop by Price" toggle within the Theme Editor for Cornerstone so that the Shop by Price section on the Category pages will not display when the toggle is disabled. When the Show "Shop by Price" toggle is disabled in the Theme Editor it will still accurately display the Price section when enabled via Faceted Search.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-3860
Screenshots (if appropriate)
Shop by Price Enabled
Shop by Price Disabled
Shop by Price Disabled with Faceted Search Enabled
@junedkazi @PascalZajac