feat(payments): PAYMENTS-3143 Add Payment Methods to Account #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new page called Payment Methods under Account - visibility of page to be controlled server side
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
💚 |
| @@ -0,0 +1,7 @@ | |||
| {{#partial "page"}} | |||
| {{> components/common/breadcrumbs breadcrumbs=breadcrumbs}} | |||
There was a problem hiding this comment.
Indentation is a bit funny here, would you mind just aligning that import with the h2 tag?
🍹
|
|
||
| {{#if settings.show_payment_methods}} | ||
| {{#if account_page '===' 'payment_methods'}} | ||
| <li class="navBar-item is-active">Payment Methods</li> |
There was a problem hiding this comment.
Missing translation here
| <li class="navBar-item is-active">Payment Methods</li> | ||
| {{else}} | ||
| <li class="navBar-item"> | ||
| <a class="navBar-action" href="/account.php?action=payment_methods">Payment Methods</a> |
danieldelcore
dismissed
their stale review
Sorry, just noticed that you're missing some translations
jackosaurus
force-pushed
the
payment-methods
branch
from
791f99c to
7e8accf
Compare
|
Merging into feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add Payment Methods to Account
Tickets / Documentation
https://jira.bigcommerce.com/browse/PAYMENTS-3143
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
@bigcommerce/payments @junedkazi