Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix category header image size #1640

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Fix category header image size #1640

merged 1 commit into from
Feb 17, 2020

Conversation

bookernath
Copy link
Contributor

What?

In Cornerstone 4.0, our move to srcset introduced a visual regression with category header images.

In 3.5.1, they appeared full-width:

image

In 4.0+, they appear miniscule:

image

This PR gives them an explicit width: 100% which works better with srcset than the previous CSS which was only max-width: 100%.

Thus, the end result:

image

Tickets / Documentation

@bigbot
Copy link

bigbot commented Feb 16, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@bookernath bookernath merged commit e7ed4ed into bigcommerce:master Feb 17, 2020
@bookernath bookernath deleted the STRF-7374 branch February 17, 2020 17:05
@bookernath bookernath mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bookernath @bigbot @junedkazi