fix(storefront): STRF-5678 fixed the check for max length in create account fields #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount form fields
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
@bc-nataliya can we please verify if we need to do the same for text area as well ?
https://github.com/bigcommerce/cornerstone/blob/master/templates/components/common/forms/multiline.html
|
@junedkazi multiline doesn't have an option of setting max length |
bookernath
reviewed
Mar 12, 2020
| @@ -2,5 +2,5 @@ | |||
| <label class="form-label" for="{{id}}_input">{{label}} | |||
| {{#if required}}<small>{{lang 'common.required' }}</small>{{/if}} | |||
| </label> | |||
| <input type="text" id="{{id}}_input" data-label="{{label}}" name="{{name}}" {{#if value}} value="{{value}}"{{/if}} {{#if placeholder}} placeholder="{{placeholder}}"{{/if}} class="form-input" aria-required="{{required}}" {{#if private_id}}data-field-type="{{private_id}}"{{/if}}> | |||
| <input type="text" id="{{id}}_input" data-label="{{label}}" name="{{name}}" {{#if value}} value="{{value}}"{{/if}} {{#if placeholder}} placeholder="{{placeholder}}"{{/if}} class="form-input" aria-required="{{required}}" {{#if private_id}}data-field-type="{{private_id}}"{{/if}} {{#if maxlength}}maxlength="{{maxlength}}"{{/if}}> | |||
There was a problem hiding this comment.
You could consider putting the space inside the {{#if}} block so it only makes it to the markup if this argument is used 🍹
bookernath
approved these changes
Mar 12, 2020
junedkazi
changed the title
|
tested on integration
looks good 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Top 20 bug reports that while user can set the max length for the account sign up fields it is not respected in the storefront
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-5678
Screenshots (if appropriate)
To test:
ping @bigcommerce/storefront-team @bigcommerce/artemis-dt