Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payments): INT-3211 Change width size for apple pay button #1862

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

BC-MLoyo-zz
Copy link
Contributor

@BC-MLoyo-zz BC-MLoyo-zz commented Oct 5, 2020

What?

Change the width size for apple pay button in order to avoid button size varies

Tickets / Documentation

Ticket

Screenshots (if appropriate)

Desktop
Screen Shot 2020-10-05 at 18 30 37

Safari responsive mode emulating iPhone 8 Plus
Screen Shot 2020-10-05 at 18 31 02

@bigbot
Copy link

bigbot commented Oct 5, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@BC-MLoyo-zz BC-MLoyo-zz changed the title fix(payments): INT-3211 Change width size for apple pay button [WIP] fix(payments): INT-3211 Change width size for apple pay button Oct 5, 2020
@BC-MLoyo-zz BC-MLoyo-zz changed the title [WIP] fix(payments): INT-3211 Change width size for apple pay button fix(payments): INT-3211 Change width size for apple pay button Oct 5, 2020
@BC-MLoyo-zz BC-MLoyo-zz marked this pull request as ready for review October 5, 2020 23:42
Copy link

@vmparra vmparra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@pgonzalezr
Copy link

Looks good from QE side, buttons are displayed correctly in iPhone, iPad & Desktop resolutions 💚

@LauraGerlach1 LauraGerlach1 added ready to merge Pull request that have been approved and are waiting to be merged reviewed and removed reviewable labels Oct 9, 2020
@PascalZajac PascalZajac merged commit 4b09dd0 into bigcommerce:master Oct 12, 2020
@BC-MLoyo-zz BC-MLoyo-zz deleted the INT-3211 branch October 13, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations ready to merge Pull request that have been approved and are waiting to be merged reviewed sydney
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants