BIG-22753 & BIG-22754 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .icon { | ||
| position: relative; | ||
| top: -1px; |
There was a problem hiding this comment.
Beautiful hacky goodness to actually middle align icons inside buttons (as vertical-align fails, possibly due to the way it renders on an odd pixel height - which is to push it down a little too much).
|
👍 |
| &:hover { | ||
|
|
||
| svg { | ||
| fill: stencilColor("icon-color-hover"); |
There was a problem hiding this comment.
why is the above --hover, but here it's -hover?
There was a problem hiding this comment.
Oh the "color-textSecondary--hover"?
Gotcha. Inconsistencies in our naming patterns. I noticed that too. I'm doing a bunch of work on all of the variables in the config json, and these will all go away once I'm through with the variant jira's. So live with it for now, but it will be going away.
|
@SiTaggart @bc-miko-ademagic Take another look at this shizzle too plz |
|
👍 |
bc-chris-roper
force-pushed
the
BIG-22754
branch
from
defeea3 to
4dd7f92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several minor fixes and enhancements for Light & Bold variants. See attached visual for an example of local code running on my machine.
For testing purposes, this ticket fixes the issues outlined in BIG-22753 and BIG-22754.
@bc-miko-ademagic @SiTaggart