BIG-22960 Add data attributes for banner automation. #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM, ignore the build failure, there are no tests and it can't clone the repo. |
hegrec
added a commit
that referenced
this pull request
Oct 28, 2015
BIG-22960 Add data attributes for banner automation.
|
Just for curiosity, why do we need those data attributes? |
|
Test isolation. When you hook UI automation tests to class names, just like hooking JS actions to class names, 9 times out of 10, someone will refactor something and will break those tests. We style classnames, they are open for removal, moving, completely throw away. Personally I would namespace them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hegrec @SiTaggart