BIG-22371 - Add validation to search boxes #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.validator.add({ | ||
| selector: this.$form.find(element), | ||
| validate: 'presence', | ||
| errorMessage: 'Search field cannot be blank' |
There was a problem hiding this comment.
Translation please. You can add it to an element attribute:
errorMessage: $(element).data('error-message')
|
👍 LGTM, one thing I might do is move each of the chained calls to their own lines like we do in PHP 🍹 |
|
Like so? let validator = internals.initValidation($quickSearchDiv)
.bindValidation($quickSearchDiv.find('#search_query')); |
|
Yep, It's easier to see in steps what is happening |
|
Done! |
mickr
pushed a commit
that referenced
this pull request
Oct 29, 2015
BIG-22371 - Add validation to search boxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIG-22371