Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIG-22968 Dom helpers for tests #617

Closed
wants to merge 1 commit into from
Closed

BIG-22968 Dom helpers for tests #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions templates/components/common/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<footer class="footer" role="contentinfo">
<div class="container">
<section class="footer-info">
<article class="footer-info-col footer-info-col--small">
<article class="footer-info-col footer-info-col--small" data-section-type="webPages">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to prefix this names with footer-

data-section-type="footer-webPages"
data-section-type="footer-categories"
...

<h5 class="footer-info-heading">{{lang 'footer.navigate'}}</h5>
<ul class="footer-info-list">
{{#each pages}}
Expand All @@ -21,7 +21,7 @@ <h5 class="footer-info-heading">{{lang 'footer.navigate'}}</h5>
</ul>
</article>

<article class="footer-info-col footer-info-col--small">
<article class="footer-info-col footer-info-col--small" data-section-type="categories">
<h5 class="footer-info-heading">{{lang 'footer.categories'}}</h5>
<ul class="footer-info-list">
{{#each categories}}
Expand All @@ -32,7 +32,7 @@ <h5 class="footer-info-heading">{{lang 'footer.categories'}}</h5>
</ul>
</article>

<article class="footer-info-col footer-info-col--small">
<article class="footer-info-col footer-info-col--small" data-section-type="brands">
<h5 class="footer-info-heading">{{lang 'footer.brands'}}</h5>
<ul class="footer-info-list">
{{#each shop_by_brand}}
Expand All @@ -44,15 +44,15 @@ <h5 class="footer-info-heading">{{lang 'footer.brands'}}</h5>
</ul>
</article>

<article class="footer-info-col footer-info-col--small">
<article class="footer-info-col footer-info-col--small" data-section-type="storeInfo">
<h5 class="footer-info-heading">{{lang 'footer.info'}}</h5>
<address>{{nl2br settings.address}}</address>
{{#if settings.phone_number}}
<strong>{{lang 'footer.call_us' phone_number=settings.phone_number}}</strong>
{{/if}}
</article>

<article class="footer-info-col">
<article class="footer-info-col" data-section-type="newsletterSubscription">
{{#if settings.show_newsletter_box}}
{{> components/common/subscription-form }}
{{/if}}
Expand Down