Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma warning solution #48

Merged
merged 50 commits into from
Mar 17, 2022
Merged

Pragma warning solution #48

merged 50 commits into from
Mar 17, 2022

Conversation

galanCA
Copy link
Contributor

@galanCA galanCA commented Mar 15, 2022

Create a solution for third-party headers files using pragma disable warnings.

@galanCA galanCA added the bug label Mar 15, 2022
@galanCA galanCA self-assigned this Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #48 (571286b) into develop (09511bc) will increase coverage by 0.10%.
The diff coverage is 71.26%.

@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
+ Coverage    59.10%   59.20%   +0.10%     
===========================================
  Files           21       21              
  Lines         5066     5064       -2     
===========================================
+ Hits          2994     2998       +4     
+ Misses        2072     2066       -6     
Flag Coverage Δ
integration 59.20% <71.26%> (+0.10%) ⬆️
unit 59.20% <71.26%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/libkiva/Mesher.cpp 78.99% <25.00%> (-1.47%) ⬇️
src/libkiva/Ground.cpp 78.62% <40.91%> (ø)
src/libgroundplot/GroundPlot.cpp 44.56% <83.33%> (+0.15%) ⬆️
src/kiva/Simulator.cpp 70.31% <87.50%> (ø)
src/libkiva/Foundation.cpp 40.62% <90.48%> (+0.19%) ⬆️
src/libkiva/Aggregator.cpp 91.11% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09511bc...571286b. Read the comment docs.

@galanCA galanCA requested a review from nealkruis March 16, 2022 16:55
@galanCA galanCA marked this pull request as ready for review March 16, 2022 16:55
@nealkruis nealkruis merged commit 1c699e7 into develop Mar 17, 2022
@nealkruis nealkruis deleted the pragma-warning-solution branch March 17, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants