Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select correct rows #324

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix: select correct rows #324

merged 1 commit into from
Apr 19, 2023

Conversation

ESCRI11
Copy link
Contributor

@ESCRI11 ESCRI11 commented Apr 19, 2023

This closes #318

Description

The error was being originated when evaluating the following line 64bbccf#diff-7fee6935f3c7a80f87c56c1d2d61dfad16e2bc9bdce3f6530753c7e4ab0490d3R118

The error was that the sel row selector was targeting rows non existent on the R table.

This sel vector is defined here, it is basically a 1:N vector where N is selected on the righ-bar-settings, when filtering genes this R table had less than N rows so it crashed.

Now we check if N is bigger than the rows of R.

@ESCRI11 ESCRI11 requested a review from mauromiguelm April 19, 2023 12:32
Copy link
Contributor

@mauromiguelm mauromiguelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works well, approved, but why is pcor_ntop giving out of bounds, when is should be a subset of rownames(R)? do we have a problem with R <- getGeneCorr() or pcor_ntop?

@ivokwee ivokwee merged commit 8f9aa82 into master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expression > Correlation analysis > correlation > plot top correlated genes
3 participants