Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot download #330

Merged
merged 6 commits into from
Apr 23, 2023
Merged

Fix plot download #330

merged 6 commits into from
Apr 23, 2023

Conversation

mauromiguelm
Copy link
Contributor

See last comments on #289.

We have three plots not working, to avoid the risk of breaking the others (no comprehensive tests), I could disable download for the ones that are not working.

@mauromiguelm mauromiguelm requested review from ESCRI11 and ivokwee April 21, 2023 13:01
@mauromiguelm mauromiguelm linked an issue Apr 21, 2023 that may be closed by this pull request
@mauromiguelm
Copy link
Contributor Author

Disabled download for the three plots that are not working:

PDF disabled
[png=OK,pdf=failed] Single Cell Board > Markers > Expression of marker genes (ggplot/grid) investigate, pdf indeed not working

entire download disabled
[failed] Single Cell Board > Markers > Cytometry plot (ggplot/grid) investigate, confirmed not working

entire download disabled
[failed] Clustering > WGCNA (beta) > Modules > Module-Trait relationships (base) investigate, confirmed not working

@mauromiguelm mauromiguelm self-assigned this Apr 21, 2023
@ivokwee ivokwee merged commit 1aa35e0 into master Apr 23, 2023
@mauromiguelm mauromiguelm deleted the fix-plot-download branch April 23, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some plots cannot be downloaded PNG/PDF
2 participants