Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#335: from tipify to withToolTip #339

Merged
merged 1 commit into from
Apr 25, 2023
Merged

#335: from tipify to withToolTip #339

merged 1 commit into from
Apr 25, 2023

Conversation

ESCRI11
Copy link
Contributor

@ESCRI11 ESCRI11 commented Apr 25, 2023

This closes #335

Description

Replaced all tipify/tipify2 with withToolTips

@ESCRI11 ESCRI11 requested a review from ivokwee April 25, 2023 13:44
@ivokwee
Copy link
Member

ivokwee commented Apr 25, 2023

Xavier. Do you perhaps know, or can you create, a server-side function that adds a tooltip to an element, like addTooltip('my_input','Hello world!')

@ESCRI11
Copy link
Contributor Author

ESCRI11 commented Apr 25, 2023

I am not sure I follow what you have in mind. Can you please provide some more context on what should be the output of such function?

@ivokwee
Copy link
Member

ivokwee commented Apr 25, 2023

OK. Thanks. BTW withTooltips is not actually using options. It was just kept for compatibility/laziness.... see ui/ui-tooltip.R.

@ivokwee ivokwee merged commit 4267df0 into master Apr 25, 2023
@ivokwee
Copy link
Member

ivokwee commented Apr 25, 2023

See for example here shinyBS::addTooltip
https://ebailey78.github.io/shinyBS/docs/Tooltips_and_Popovers.html

We used shinyBS before but it gave quite a few UI problems of tooltips that didn't disappear. So John switched to the built-in bootstrap tooltips. My idea is to programatically add a tooltip to buttons that are disabled and give some explanation and change the tooltip message from the server.

@ESCRI11 ESCRI11 deleted the fix-#335 branch April 26, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tooltips in batch correction tab needs to be updated with withTooltip
2 participants