Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance general output of acmg prediction #128

Merged
merged 10 commits into from
Jun 10, 2024

Conversation

gromdimon
Copy link
Collaborator

@gromdimon gromdimon commented Jun 6, 2024

Issue:

Description:

  • N/A

TODO:

  • Tests
  • Document new output

@gromdimon gromdimon linked an issue Jun 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 43.66925% with 218 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (0c41cfd) to head (3ea454b).

Current head 3ea454b differs from pull request most recent head 14d2627

Please upload reports for the commit 14d2627 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   65.09%   60.87%   -4.23%     
==========================================
  Files          28       28              
  Lines        2467     2538      +71     
==========================================
- Hits         1606     1545      -61     
- Misses        861      993     +132     
Files Coverage Δ
src/defs/auto_pvs1.py 98.87% <100.00%> (+0.01%) ⬆️
src/pvs1/auto_pvs1.py 80.00% <100.00%> (-4.10%) ⬇️
src/auto_acmg.py 84.44% <78.57%> (-3.20%) ⬇️
src/criteria/auto_ba1_bs1_bs2_pm2.py 23.25% <40.00%> (-0.56%) ⬇️
src/pvs1/strucvar_pvs1.py 33.00% <50.00%> (+0.35%) ⬆️
src/defs/auto_acmg.py 95.39% <91.17%> (-3.93%) ⬇️
src/criteria/auto_pm4_bp3.py 30.35% <20.00%> (-4.34%) ⬇️
src/criteria/auto_ps1_pm5.py 58.75% <33.33%> (-7.92%) ⬇️
src/criteria/auto_bp7.py 22.98% <10.52%> (-3.68%) ⬇️
src/criteria/auto_pp2_bp1.py 20.83% <19.04%> (-4.46%) ⬇️
... and 4 more

@gromdimon gromdimon merged commit 42eac56 into main Jun 10, 2024
4 checks passed
@gromdimon gromdimon deleted the 127-enhance-general-output-of-acmg-prediction branch June 10, 2024 19:03
gromdimon added a commit that referenced this pull request Aug 2, 2024
* initilize new result model

* PVS1

* other criteria

* remove artifacts

* export method

* solve linting problems

* fix failing tests

* fix e2e tests

* add config=config to super().__init__

* add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance general output of ACMG prediction
1 participant