Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename base test classes #2001

Closed
mikkonie opened this issue Sep 13, 2024 · 1 comment
Closed

Rename base test classes #2001

mikkonie opened this issue Sep 13, 2024 · 1 comment
Assignees
@mikkonie
Labels
app: landingzones Issue in the landingzones app app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone
v1.0.0

Comments

@mikkonie
Copy link
Contributor

These should be renamed to the scheme set in SODAR v1.0 for consistency. Instead of TestXXXBase it should be XXXTestBase

This is done because Test* classes denote tests and no actual tests are performed in these base classes.

It seems this has previously mostly been done, but some classes with incorrect names still remain.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: samplesheets Issue in the samplesheets app app: landingzones Issue in the landingzones app labels Sep 13, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Sep 13, 2024
@mikkonie mikkonie self-assigned this Sep 13, 2024
mikkonie added a commit that referenced this issue Sep 13, 2024
@mikkonie
refactor tests (#1991, #2001, #2002)
3ee4e53
@mikkonie
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: landingzones Issue in the landingzones app app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@mikkonie