Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetToken does not support query parameters #57

Closed
phoorichet opened this issue Jul 18, 2019 · 1 comment
Closed

GetToken does not support query parameters #57

phoorichet opened this issue Jul 18, 2019 · 1 comment

Comments

@phoorichet
Copy link

Query GetToken function does not expose query params to the caller.

https://github.com/binance-chain/go-sdk/blob/98a01c4963488fb43ade98680ff8158c41e12030/client/query/get_tokens.go#L10-L12

In the API reference, Get tokens list allows limit and offset so the client can optionally manipulate these values.

When the number of issued tokens is more than the default limit (which is 500), they got cut off. Thus, GetToken does not return the correct list of all tokens.
@phoorichet phoorichet changed the title GetToken does not support query params GetToken does not support query parameters Jul 18, 2019
@unclezoro
Copy link
Contributor

thks for your report. The issue is going to fixed in #58

unclezoro added a commit that referenced this issue Jul 22, 2019
@unclezoro
[R4R]add query option to getTokens api, resolve issue #57 (#58)
2946491 
* add query option to getTokens api

* add offset check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phoorichet @unclezoro