[R4R]add query option to getTokens api, resolve issue #57 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
changed the title
unclezoro
changed the title
ackratos
previously approved these changes
Jul 22, 2019
yutianwu
reviewed
Jul 22, 2019
| } | ||
|
|
||
| func (param *OrdersQuery) Check() error { | ||
| if param.Limit != nil && *param.Limit <= 0 { |
HaoyangLiu
reviewed
Jul 22, 2019
| // OrdersQuery definition | ||
| type OrdersQuery struct { | ||
| Offset *uint32 `json:"offset,omitempty,string"` //Option | ||
| Limit *uint32 `json:"limit,omitempty,string"` //Option |
There was a problem hiding this comment.
Why do you use pointer?
There was a problem hiding this comment.
The field is optional, use can not assign them so that will use default by backend service.
If not use pointer, will always send a query parameter to backend service
HaoyangLiu
previously approved these changes
Jul 22, 2019
yutianwu
previously approved these changes
Jul 22, 2019
HaoyangLiu
approved these changes
Jul 22, 2019
ackratos
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.