Avoiding empty attributes from CVE search result's

binareio · Aug 15, 2024 · 84e1a43 · 84e1a43
1 parent 78b5a65
commit 84e1a43
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/common/models/cve.py b/src/common/models/cve.py
@@ -177,7 +177,7 @@ class Config:
 
 class CveItem(BaseModel):
     class Config:
-        extra = Extra.forbid
+        extra = Extra.ignore
 
     id: constr(regex=r'^CVE-[0-9]{4}-[0-9]{4,}$')
     sourceIdentifier: Optional[str] = None

diff --git a/src/web/routers/search.py b/src/web/routers/search.py
@@ -40,7 +40,7 @@ def search(appctx: ApplicationContext, opts: SearchOptions) -> any:
 
 
 # ------------------------------------------------------------------------------
-@router.get("/cve", name="Search CVE", response_model=CveOutput)
+@router.get("/cve", name="Search CVE", response_model=CveOutput, response_model_exclude_unset=True)
 async def search_cve(cmn_opts: SearchInputCommon = Depends(SearchInputCommon),
                      cve_opts: SearchInputCve = Depends(SearchInputCve),
                      appctx: ApplicationContext = Depends(get_app_cntxt),
@@ -80,7 +80,7 @@ async def search_cve(cmn_opts: SearchInputCommon = Depends(SearchInputCommon),
 
 
 # ------------------------------------------------------------------------------
-@router.get("/cpe", name="Search CPE", response_model=CpeOutput)
+@router.get("/cpe", name="Search CPE", response_model=CpeOutput, response_model_exclude_unset=True)
 async def search_cpe(cmn_opts: SearchInputCommon = Depends(SearchInputCommon),
                      cpe_opts: SearchInputCpe = Depends(SearchInputCpe),
                      appctx: ApplicationContext = Depends(get_app_cntxt),

diff --git a/tests/unit/test_cve_search.py b/tests/unit/test_cve_search.py
@@ -8,7 +8,6 @@
 def test_cve_search_by_id(cli_runner):
     """Search CVEs by ID and requests output as ID"""
 
-    import pdb; pdb.set_trace()
     result = cli_runner.runcommand("docker exec fastcve search --search-info cve --cve CVE-1999-0001 --output id")
     assert result.returncode == 0
     assert result.stdout[:13] == 'CVE-1999-0001'