Feature/gradle kotlin dsl compatibility #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaced all String[] attributes on the BintrayExtension by List<String> and initialized them with empty lists. - configurations and publications can now be properly added by using .add(...) on the initialized list attributes of BintrayExtension. - aligned the attribute types on the BintrayUploadTask. - update the empty check on the publications and configurations attributes in the BintrayPlugin class.
|
Hello @teyckmans , do you know if this PR solves this issue. |
|
Hi @GuilhE , I don't think I had a problem accessing the extension it was just not that handy to use with the Kotlin build scripts. In this build https://github.com/teyckmans/ui-rig/blob/master/ui-rig-core/build.gradle.kts I was testing the changes. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was converting my groovy gradle build files and was not able to assign publications on the extension class. These are really small changes that make it possible to use this plugin when using kotlin gradle build files.
What changed: